Cube root function #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertcandav
requested changes
Oct 27, 2025
Member
mertcandav
left a comment
mertcandav
left a comment
There was a problem hiding this comment.
Hi,
Unfortunately, I've encountered a few issues that need to be addressed before we can merge your PR:
- The CI pipeline is currently failing. Please check the CI logs for details.
- The code must be fully compatible with the latest Jule version.
- Please ensure your tests are correctly placed in the designated test file, following the existing structure.
- The source code should not include an entry point (
main) function.
Once these points are resolved, I will review it again.
Thanks.
Member
|
Closed due to no progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new cube root function to the math utilities and documents its inclusion. The main change is the implementation of the cube root calculation for floating-point numbers, along with example usage and thorough testing to ensure correctness.
Math utilities enhancement:
cbrtfunction inmath/cube_root.juleto calculate the cube root of a givenf64value, correctly handling negative inputs.cbrt, covering positive, negative, zero, and fractional cases with floating-point tolerance checks.mainfunction to demonstrate how to use the new cube root function.Documentation update:
Cube Rootto the math section ofDIRECTORY.md, listing the new utility for discoverability.